Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass through BigQuery Config in multithreaded worker (closes #2298) #2299

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

justin-plancraft
Copy link

This closes #2298 by passing through the bqProjectConfig :)

Copy link

google-cla bot commented Feb 20, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@cabljac cabljac self-assigned this Feb 28, 2025
@cabljac
Copy link
Contributor

cabljac commented Feb 28, 2025

Hi, thanks for the contribution! I'll review and try to get this out ASAP

Copy link
Contributor

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cabljac
Copy link
Contributor

cabljac commented Feb 28, 2025

I'm just going to run some end to end tests on it, then i'll push a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [fs-bq-import-collection] Multi-Threaded import Script does not Support Cross-Project loading
2 participants